[FFmpeg-devel] [PATCH] Optimization of original IFF codec

[Jai Menon]

On Fri, Apr 23, 2010 at 3:04 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Hey again!
>
> M?ns Rullg?rd a ?crit :
>> That one in particular is easier to read before your patch. ?If the
>> compiler does the right thing with our default settings, leave it.
>>
> Although we discussed this yesterday in #ffmpeg-devel I'm replying to
> this, so others here who didn't read the log at least know what's going on.
>
> We already found out that the compiler won't replace the / with >> since
> signed division differs from bit-shift right. We discussed that I shall
> change this stuff to unsigned then.

yes

> I'll do a patch for this soon, but I want to mention though, that the
> code in IFF does fiddle with bit-planar modes, thus the data is expected
> to be calculated bit-wise. In that case I find it more readable to use
> << and >> instead of * and /.

the readability in question here is subjective and what the maintainer prefers.

[...]

-- 
Jai Menon