[FFmpeg-devel] [PATCH] Optimization of original IFF codec

Sebastian Vater cdgs.basty
Sun Apr 25 21:56:46 CEST 2010


Ok you're right, have fixed it!

Ronald S. Bultje a ?crit :
> Hi,
>
> On Sun, Apr 25, 2010 at 3:02 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>   
>> Ronald S. Bultje a ?crit :
>>     
>>>> -                decodeplane32(row, buf, FFMIN(s->planesize, buf_end - buf), avctx->bits_per_coded_sample, plane);
>>>>         
>>> [..]
>>>       
>>>> +                decodeplane32((uint32_t *) row, buf, FFMIN(s->planesize, buf_end - buf), avctx->bits_per_coded_sample, plane);
>>>>         
>>> Why did you add the cast? Is that necessary?
>>>
>>>       
>> Yes because I changed decodeplane from void * to uint8_t * and uint32_t
>> *, the cast removes a nasty GCC warning about incompatible
>> pointer-assignment ;)
>>     
>
> I don't see where you change that (maybe wrong patch again?).
>   

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-opt-restruct-noindent.patch
Type: text/x-patch
Size: 4216 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100425/67c7779a/attachment.bin>



More information about the ffmpeg-devel mailing list