[FFmpeg-devel] [PATCH] Optimization of original IFF codec

[Sebastian Vater]

Ronald S. Bultje a ?crit :
> Hi,
>
> On Sun, Apr 25, 2010 at 3:56 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>   
>> Ok you're right, have fixed it!
>>     
> [..]
>   
>> -            } else { // PIX_FMT_BGR32
>> +            buf += s->planesize;
>> +        }
>> +    }
>> +    } else { // PIX_FMT_BGR32
>>     
>
> The indenting of the first 3 new lines is off by 4 (there should be 4
> more spaces each).
>   
Fixed.
>>                      decodeplane8(row, s->planebuf, s->planesize, avctx->bits_per_coded_sample, plane);
>> -                } else { //PIX_FMT_BGR32
>> +                    }
>> +                }
>> +        } else { // PIX_FMT_BGR32
>>     
>
> I'm not sure if the indenting is off here in the same way, could you check that?
>   
Fixed.
> Also, feel free to send a cosmetic patch to fix indenting (separately)
> along with your next patch, this patch looks fine along for these
> minor things and then I'll apply both at once.
>   
Okay.

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-opt-restruct-noindent.patch
Type: text/x-patch
Size: 4153 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100425/847cda97/attachment.bin>