[FFmpeg-devel] [PATCH] Reintroduce nb_frames in ffprobe

Robert Krüger krueger
Mon Apr 26 07:50:39 CEST 2010


On 26.04.2010, at 01:38, Stefano Sabatini wrote:

> On date Tuesday 2010-04-20 10:06:18 +0200, Robert Kr?ger encoded:
>> 
>> On 20.04.2010, at 00:56, Stefano Sabatini wrote:
>> 
>>> On date Wednesday 2010-04-14 22:19:26 +0200, Robert Kr?ger encoded:
>>>> 
>>>> On 14.04.2010, at 11:01, Robert Kr?ger wrote:
>>>> 
>>>>> 
>>>>> Reintroduce nb_frames in ffprobe as it used to work in the sourceforge version.
>>>>> 
>>>>> Regards,
>>>>> 
>>>>> Robert
>>>>> 
>>>>> <ffprobe-add-nb-frames.patch>
>>>>> 
>>>> 
>>>> the same with the correct format.
>>> 
>>> I noticed that with most streams I tested this is set to 0, from
>>> avformat.h:
>>> 
>>> int64_t nb_frames; ///< number of frames in this stream if known or 0
>>> 
>>> Maybe this also should print "N/A" in case of unknown number of
>>> frames, thinking about that...
>> 
>> makes sense and is consistent with the way this is handled for other
>> values. Once you say what you prefer (see other mail), I can submit
>> a patch.
> 
> Applied the simplest variant, I still cannot find a compelling reason
> for preferring one solution against the other.
> 

OK, thanks! So the aspect ratios are going to be treated similarly, i.e. if not known, they are not being output? Do you want me to submit a patch for that?

Regards,

Robert




More information about the ffmpeg-devel mailing list