[FFmpeg-devel] [PATCH] Optimization of original IFF codec

[Michael Niedermayer]

On Mon, Apr 26, 2010 at 06:40:19PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Apr 25, 2010 at 4:21 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
> > Ronald S. Bultje a ?crit :
> >> On Sun, Apr 25, 2010 at 3:56 PM, Sebastian Vater
> >> <cdgs.basty at googlemail.com> wrote:
> >>
> >>> Ok you're right, have fixed it!
> >>>
> >> [..]
> >>
> >>> - ? ? ? ? ? ?} else { // PIX_FMT_BGR32
> >>> + ? ? ? ? ? ?buf += s->planesize;
> >>> + ? ? ? ?}
> >>> + ? ?}
> >>> + ? ?} else { // PIX_FMT_BGR32
> >>>
> >>
> >> The indenting of the first 3 new lines is off by 4 (there should be 4
> >> more spaces each).
> >>
> > Fixed.
> >>> ? ? ? ? ? ? ? ? ? ? ?decodeplane8(row, s->planebuf, s->planesize, avctx->bits_per_coded_sample, plane);
> >>> - ? ? ? ? ? ? ? ?} else { //PIX_FMT_BGR32
> >>> + ? ? ? ? ? ? ? ? ? ?}
> >>> + ? ? ? ? ? ? ? ?}
> >>> + ? ? ? ?} else { // PIX_FMT_BGR32
> >>>
> >>
> >> I'm not sure if the indenting is off here in the same way, could you check that?
> >>
> > Fixed.
> 
> Applied.

benchmark of before and after this patch?
it adds code duplication and its not clear if it would be faster as it
does not change the inner loop

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100427/b3cb0879/attachment.pgp>