[FFmpeg-devel] [PATCH] Optimization of original IFF codec

[Ronald S. Bultje]

Hi,

On Tue, Apr 27, 2010 at 9:52 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Apr 27, 2010 at 09:47:21AM -0400, Ronald S. Bultje wrote:
>> On Mon, Apr 26, 2010 at 8:18 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > benchmark of before and after this patch?
>>
>> http://permalink.gmane.org/gmane.comp.video.ffmpeg.devel/108278
>>
>> > it adds code duplication and its not clear if it would be faster as it
>> > does not change the inner loop
>>
>> Mans and I both reviewed the code and there hadn't been any comments
>> since I and he first OK'ed the patch a few days ago. The code
>> duplication is relatively minor and it seemed we were both OK with
>> it...
>>
>> I agree ~2% isn't much, we discussed different types of optimizations
>> and a more systematic approach towards this on IRC, but hey, it's 2%.
>
> i agree that 2% justifies the change, i had not seen/realized this was
> benchmarked seperate from other changes assuming it has ...
>
> also i doubt slightly that this change truly causes a 2% speed change
> absent of gcc being more stupid prior to this change. Doesnt really
> matter though, faster is faster and thus better ...

For what it's worth, Mans expressed similar opinions on IRC...

Ronald