[FFmpeg-devel] [PATCH] Add IFF metadata handling

[Sebastian Vater]

Vladimir Pantelic a ?crit :
> Vladimir Pantelic wrote:
>> Sebastian Vater wrote:
>>>  Vladimir Pantelic a ?crit :
>>>>   Sebastian Vater wrote:
>>>>>   Hi guys!
>>>>>
>>>>>   Just did a small patch which adds new IFF metadata stuff.
>>>>>
>>>>>   The original IFF demuxer just processed the comment metadata stuff,
>>>>>   therefore I added title, copyright and author metadata stuff to IFF
>>>>>   demuxer.
>>>>>
>>>>>   It's really a small patch and shouldn't be of any problems.
>>>>>
>>>>
>>>>   +            buf = av_malloc(data_size + 1);
>>>>   +            if (!buf)
>>>>   +                break;
>>>>   +            get_buffer(pb, buf, data_size);
>>>>   +            buf[data_size] = 0;
>>>>
>>>>   could be factored out
>>>
>>>  Factored out? Do you mean putting it into a #define and just call the
>>>  define's?
>>
>> what is wrong with a function?

Oh, you're right. Patch fixing this attached!
Also I forgot to handle TEXT chunk, which does the same as ANNO (add
comment metadata).

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-metadata.patch
Type: text/x-diff
Size: 1791 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100430/b76ed259/attachment.patch>