[FFmpeg-devel] [PATCH] Fix the wmavoice-7k fate test (failures on OpenBSD)
Martin Storsjö
martin
Sat Aug 7 12:12:13 CEST 2010
Hi,
I checked out the wmavoice-7k fate test failures that occurred on OpenBSD,
and actually got crashes in these tests on Mac OS X, too, under some
compilation configurations.
I tracked down the issue to aw_pulse_set2, where the loop around lines
1071- may write outside of the use_mask buffer if pulse_off starts out
negative.
The first patch fixes the issue and makes the test pass on OpenBSD, but
it's a bit ugly. The second patch also fixes the issue, but changes the
output of the test (but it still sounds the same to me). I believe this is
the more correct way to fix the issue, but requires the reference sample
in the testsuite to be updated.
// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wmavoice.patch
Type: text/x-diff
Size: 1085 bytes
Desc:
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100807/85660d15/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wmavoice2.patch
Type: text/x-diff
Size: 631 bytes
Desc:
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100807/85660d15/attachment-0001.patch>
More information about the ffmpeg-devel
mailing list