[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice

[Diego Biurrun]

On Sat, Aug 07, 2010 at 11:17:24PM -0400, Brad wrote:
> On Sat, Aug 07, 2010 at 11:11:23PM -0400, Brad wrote:
> > On Mon, Aug 02, 2010 at 07:42:28PM -0400, Brad wrote:
> > > sndio is a relatively new audio API utilized by OpenBSD.
> > > 
> > > Below is a patch to add sndio playback and record support
> > > to FFmpeg.
> > > 
> > > I believe I have touched everything that needs updating
> > > including documentation such as the recently added
> > > indevs.texi and outdevs.texi, but if not please let
> > > me know.
> > > 
> > > The sndio code was written by Jacob Meuser <jakemsr sdf lonestar org>
> > > 
> > > Please provide any feedback.
> > 
> > a third revision with the code splitting and some further clean up.
> 
> and the right diff.
> 
> --- libavdevice/sndio-common.c	(revision 0)
> +++ libavdevice/sndio-common.c	(revision 0)
> +av_cold int ff_sndio_open(AVFormatContext *s1, int is_output,
> +                       const char *audio_device)

Indentation is off.  How hard can it be to get this right?  Watch:

  av_cold int ff_sndio_open(AVFormatContext *s1, int is_output,
                            const char *audio_device)

Diego