[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice

[Aurelien Jacobs]

On Sun, Aug 08, 2010 at 10:19:41PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Thu, Aug 05, 2010 at 08:21:21AM +0100, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Mon, Aug 02, 2010 at 07:42:28PM -0400, Brad wrote:
> >> >> 
> >> >> Please provide any feedback.
> >> >
> >> > Here you go..
> >> >
> >> >> --- Changelog	(revision 24666)
> >> >> +++ Changelog	(working copy)
> >> >> @@ -27,9 +27,9 @@
> >> >>  - SubRip subtitle file muxer and demuxer
> >> >>  - Chinese AVS encoding via libxavs
> >> >>  - ffprobe -show_packets option added
> >> >> +- sndio support for playback and record
> >> >>  
> >> >>  
> >> >> -
> >> >>  version 0.6:
> >> >
> >> > The empty line was there on purpose.
> >> 
> >> Care to tell us _what_ that purpose is?
> >
> > Readability, what else?
> 
> I fail to see how 3 blank lines are more readable than 2.

Agree. To me, 2 blank lines are more readable than 3.
I always wondered why those 3 lines were added. I thought it was to
comply to some stupid "standard", but certainly not for readability.

Moreover, many patch senders tend to naturally remove the third line,
only to receive a laconic email from diego asking to resend the patch
without this change. So this additionnal line adds some useless
maintenance and patch submission burden.

So I propose we just switch back to 2 lines, and end up this madness.

Aurel