[FFmpeg-devel] [HACK] Remove MAX_STREAMS usages

Ronald S. Bultje rsbultje
Tue Aug 10 00:48:59 CEST 2010


Hi,

On Mon, Aug 9, 2010 at 4:45 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> On Mon, Aug 09, 2010 at 03:46:29PM -0400, Ronald S. Bultje wrote:
>> On Mon, Aug 9, 2010 at 2:48 PM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>> > On Mon, Aug 09, 2010 at 01:20:57PM -0400, Ronald S. Bultje wrote:
>> >> > + ? ?rt->real_setup_cache = av_mallocz(2 * s->nb_streams * sizeof(*rt->real_setup_cache));
>> >>
>> >> Why 2 * ..?
>> >
>> > Because it is also used as a temporary variable to replace
>> > a on-stack variable.
>> > It might be more readable to add a second pointer to the context instead though.
>>
>> I don't mind the single alloc, but two pointers would make this a
>> little more understandable...
>
> No problem. Here it is.
>
> I only tested the RDT and RTSP changes by playing a rtps:// url with
> ffplay. I guess that's enough ?

Try rtsp://193.42.152.206/farm/193.42.152.204/encoder/wrnengus.rm

Ronald



More information about the ffmpeg-devel mailing list