[FFmpeg-devel] [PATCH] FLAC parser

[Michael Chinen]

On Tue, Aug 10, 2010 at 2:05 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Aug 09, 2010 at 05:19:01PM -0400, Justin Ruggles wrote:
>>
>> Michael Chinen wrote:
>>
>> > Here is an updated patch that combined with the previous index_entries
>> > pos patch will result in cleaner seeking for FLAC (seek directly to
>> > frame start instead of junk.)
>> > Also please don't forget the 0002 patch from the first email.
>>
>> > +/**
>> > + * @file flac_parser.c
>> > + * @brief A FLAC parser that tracks chains of headers to minimize false positives
>>
>> Don't include the file name in the @file statement.
>
> Notice that tools/patcheck should now catch this (if it does not,
> please tell). ?If you haven't yet run your code through it,
> I recommend you do so now.

Thanks, I didn't know about this tool.
It found two interesting items that I'll fix and everything else was
about non-doxy comments within functions (which I think I should
ignore).
However when I ran it with only the patch as the sole argument, it
didn't catch the @file or @brief statement.

It did say "xargs: illegal option -- d" at one point.

Michael