[FFmpeg-devel] [PATCH] Allow setting mode MONO in libmp3lame if the library is greater than 3.97

[Thierry Foucu]

On Fri, Aug 13, 2010 at 11:40 AM, Reimar D?ffinger <Reimar.Doeffinger at gmx.de
> wrote:

> On Fri, Aug 13, 2010 at 10:00:39AM -0700, Thierry Foucu wrote:
> > +    get_lame_version_numerical(&lame_version);
> > +    if (lame_version.major <= 3 && lame_version.minor < 97) {
>
> I think that isn't quite right, it would do the wrong thing
> for a (probably non-existent and not supported by us)
> 2.99 version.
>

True.. Will send a new patch for this (after the follow up question will be
answer)


> Also do we really need to support the buggy older versions?
>


Up to you. I can remove the test and be done with it.
What do the others dev think about it?



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>