[FFmpeg-devel] [HACK] Remove MAX_STREAMS usages

Michael Niedermayer michaelni
Mon Aug 16 17:13:52 CEST 2010


On Thu, Aug 12, 2010 at 06:52:54PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Aug 8, 2010 at 4:40 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > this is just a quick hack that removes all usages of
> > MAX_STREAMS.
> 
> I was looking at the MMS use of this, and one is a sanity check to
> make sure we don't add more streams then would be reasonably useless /
> probably trash repeat file / exploit code.
> 
> It seems to me such checks should be introduced elsewhere also. Is
> keeping MAX_STREAMS or a new macro at a reasonably large value (1000
> or so) ok for that? Not for size of arrays, we can forbid that in the
> doxy, but just as a sanity check.

iam ok with a MAX_STREAMS that is not in any way part of the public api/abi

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100816/683b79a8/attachment.pgp>



More information about the ffmpeg-devel mailing list