[PATCH 2/2] Add missing checks in avfilter_default_get_video_buffer().
Stefano Sabatini
stefano.sabatini-lala
Mon Aug 16 20:05:21 CEST 2010
---
libavfilter/defaults.c | 17 +++++++++++++++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/libavfilter/defaults.c b/libavfilter/defaults.c
index e275982..7a151b2 100644
--- a/libavfilter/defaults.c
+++ b/libavfilter/defaults.c
@@ -35,9 +35,12 @@ static void avfilter_default_free_buffer(AVFilterBuffer *ptr)
AVFilterBufferRef *avfilter_default_get_video_buffer(AVFilterLink *link, int perms, int w, int h)
{
AVFilterBuffer *pic = av_mallocz(sizeof(AVFilterBuffer));
- AVFilterBufferRef *ref = av_mallocz(sizeof(AVFilterBufferRef));
+ AVFilterBufferRef *ref = NULL;
int i, tempsize;
- char *buf;
+ char *buf = NULL;
+
+ if (!pic || !(ref = av_mallocz(sizeof(AVFilterBufferRef))))
+ goto fail;
ref->buf = pic;
ref->video = av_mallocz(sizeof(AVFilterBufferRefVideoProps));
@@ -58,12 +61,22 @@ AVFilterBufferRef *avfilter_default_get_video_buffer(AVFilterLink *link, int per
tempsize = av_fill_image_pointers(pic->data, ref->format, ref->video->h, NULL, pic->linesize);
buf = av_malloc(tempsize + 16); // +2 is needed for swscaler, +16 to be
// SIMD-friendly
+ if (!buf)
+ goto fail;
av_fill_image_pointers(pic->data, ref->format, ref->video->h, buf, pic->linesize);
memcpy(ref->data, pic->data, sizeof(ref->data));
memcpy(ref->linesize, pic->linesize, sizeof(ref->linesize));
return ref;
+
+fail:
+ av_free(pic);
+ av_free(ref);
+ if (ref && ref->video)
+ av_free(ref->video);
+ av_free(buf);
+ return NULL;
}
void avfilter_default_start_frame(AVFilterLink *link, AVFilterBufferRef *picref)
--
1.7.0.4
--/9DWx/yDrRhgMJTb--
More information about the ffmpeg-devel
mailing list