[FFmpeg-devel] [PATCH] #define LAVF_API_MAX_STREAMS

Aurelien Jacobs aurel
Wed Aug 18 17:26:07 CEST 2010


On Wed, Aug 18, 2010 at 08:10:09AM +0200, Reimar D?ffinger wrote:
> On Tue, Aug 17, 2010 at 09:34:50PM +0200, Aurelien Jacobs wrote:
> > On Tue, Aug 17, 2010 at 07:19:47AM -0400, Ronald S. Bultje wrote:
> > > > Overall, this is meant to ease API transition an major bump, and to
> > > > increase tests code coverage.
> > > 
> > > Your patch doesn't do any of the above yet. Are you volunteering? :-).
> > > They are good ideas.
> > 
> > I volunteer to add proper defines for each of the currently ongoing
> > transition, to test those transitions, and to demote to one which are
> > not ready to v54 instead of v53.
> > I hope somebody will catch this on the fly to integrate it into fate...
> 
> I do think the naming is rather bad, using FF_ would have made clear
> it is for internal use only, like this you should at least document
> that applications shouldn't check for these (or should they?
> Then we'd have to keep these for "forever"?)

I didn't thought much about usage by applications, but now that I think
about it, it might prove useful for some applications, but it alsa has a
big potential for trouble.
So unless someone disagree, I will rename the define to FF_API_MAX_STREAMS.
We can always decide to expose it to applications later, if the need arise.

Aurel



More information about the ffmpeg-devel mailing list