[FFmpeg-devel] [PATCH] Add libavsequencer.

[Ronald S. Bultje]

Hi,

On Wed, Aug 18, 2010 at 7:10 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Wednesday 2010-08-18 18:49:04 -0400, Ronald S. Bultje encoded:
>> Hi,
>>
>> On Wed, Aug 18, 2010 at 6:22 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Aug 18, 2010 at 06:04:20PM -0400, Ronald S. Bultje wrote:
>> >> On Wed, Aug 18, 2010 at 5:58 PM, Stefano Sabatini
>> >> <stefano.sabatini-lala at poste.it> wrote:
>> >> > So in the end I suggest this course of action: apply the lavseq patch,
>> >> > *or* if we want to add more stuff to it before to commit it, then
>> >> > maybe we should focus on the BSS. Once that's ready, we can create
>> >> > lavseq *and* immediatly commit the BSS definition.
>> >>
>> >> I don't want anything committed until I've seen all patches required
>> >> for TCM playback posted to ffmpeg-devel so we can judge whether each
>> >> component is actually necessary.
>> >
>> > did you look at this patch?
>> > its just adding a libavseq directory and what is needed in Makefile
>> > configure and some code returning version numbers for the new lib
>> > this seems quite independant of whatever would be done inside
>> > libavseq to me
>>
>> Yes. The question is whether we need a versioned libavseq. What public
>> API will be versioned?
>>
>> We already discussed that for the time being, BSS will be private
>> because we'll want to modify it a lot. The synth mixer should not be
>> public, imo. What, then needs a public API with library versioning
>> etc.?
>
> So I suggest to start to work on libavcodec, both BSS and eventually
> mixer would go there and would be *private*. ?Then we'll move them to
> libavwhatever.

I think this is best. I'd like to see patches that place BSS, synth
mixer and the TCM decoder (data in, BSS intermediate, PCM out) in
libavcodec/, and the TCM demuxer (file in, data+metadata out) in
libavformat/, so that (after applying those 4 patches) ffplay can play
TCM files.

Sebastian, can you prepare such patches so we can do a complete review
of all code required for TCM playback? I don't mind if it's big,
because eventually we'll have to review everything anyway, but
obviously smaller is better and unused/overdesigned/unnecessary/etc.
code is unacceptable. Hopefully the modplug guys can help us review
BSS also then. The nice thing of doing it this way is that we can
don't have to mark it experimental. It's just like any other codec.

Once all that is reviewed, committed, the synth mixer is good and
appears to be more broadly useful, we can consider moving it into
libavfilter (or libavcore, accessible for both libavfilter and
libavcodec), but that should not be the original goal just yet. The
original goal should be TCM playback, nothing more. Also, note how
lavseq/ is suddenly not necessary anymore.

Ronald