[FFmpeg-devel] [PATCH] Fix return value for incomplete H264 frame packets

[Pásztor Szilárd]

Michael Niedermayer:
> > I'd only like to be able to recognize the
> > differences between different causes of "no picture" from the outside. If
> > not via my hack, then via anything else that works, that's fine with me.
> > Currently lavc seems to swallow part of that information.
> 
> ive no problem with a clean patch that exports such information

And I have no problem with trying to think up a clean solution.
Two possibilities:
1. changing the xxx_decode_frame API to introduce a new return value (bad)
2. introducing a small "accessor" function in the wrapper that, upon a direct
call to it, provides the information that was set during the last call to
avctx->codec->decode() about the current packet needing delay or not.

What do you think of the 2nd option (before I make a patch)? This way, with a
controlled default value for this info flag, all current interfaces remain
untouched, no decoders become more broken than they are now, and player
applications are free to do with the exported value whatever they want.

s.

              ---------------------------------------------------
              |  I have too much blood in my beer circulation.  |
              ---------------------------------------------------