[FFmpeg-devel] [PATCH] move h264 chromaMC x86 code to yasm

[Eli Friedman]

On Sat, Aug 28, 2010 at 4:40 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Sat, Aug 28, 2010 at 7:31 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> On Sat, Aug 28, 2010 at 4:14 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>> as per subj. FATE passes on x86-32/64 OSX and this patch fixes
>>> fate-vp6 on Win64 (which currently fails because of unmarked
>>> clobbering of xmm registers). There's some nice optimizations that
>>> could be done after this is applied, e.g. adding rv40 ssse3 mc should
>>> be easy-as-hell, but all that is left for later.
>>
>> Are you sure this actually compiles with, for example, --disable-everything?
>
> Didn't test yet... Jason says yasm doesn't have access to
> CONFIG_xyz_DECODER macros, it probably should, or I'd have to split
> these .asm files in ten smaller .asm files with various levels of
> includability, which would suck major ass...

Err, it's not such a big deal if we include unused functions in yasm
code... the issue I'm wondering about is dsputil_mmx.c unconditionally
referencing functions which are only compiled if h264dsp is enabled.

-Eli