[FFmpeg-devel] PATCH: fix crash @ deinterlace.asm missing .text section

[Michael Niedermayer]

On Sun, Nov 28, 2010 at 10:15:39PM +0800, avcoder wrote:
> Dear:
> 
> the yasm version's deinterlace forgets the .text section, all codes are
> compiled into data section currently, it will cause exception at runtime.
> 
> the following tiny patch fixes this issue
> 
> diff --git a/libavcodec/x86/deinterlace.asm b/libavcodec/x86/deinterlace.asm
> index 5db9464..76a096e 100644
> --- a/libavcodec/x86/deinterlace.asm
> +++ b/libavcodec/x86/deinterlace.asm
> @@ -27,6 +27,8 @@ SECTION_RODATA
> 
>  cextern pw_4
> 
> +SECTION .text
> +
>  %macro DEINTERLACE 1
>  %ifidn %1, inplace
>  ;void ff_deinterlace_line_inplace_mmx(const uint8_t *lum_m4, const uint8_t
> *lum_m3, const uint8_t *lum_m2, const uint8_t *lum_m1, const uint8_t *lum,
>  int size)
> 
> 
> -- 
> -----------------------------------------------------------------------------------------
> My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2

>  deinterlace.asm |    2 ++
>  1 file changed, 2 insertions(+)
> 8b0e832aaa5a8aaf895e52069bc88b0ff89d89c5  deinterlace_need_text_section.patch
> diff --git a/libavcodec/x86/deinterlace.asm b/libavcodec/x86/deinterlace.asm

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101201/4e4518b6/attachment.pgp>