[FFmpeg-devel] [PATCH] fix seek in particular ASF file

[Michael Niedermayer]

On Fri, Dec 03, 2010 at 08:54:36AM +0100, Stefan Gehrer wrote:
> On 11/30/2010 01:35 AM, Michael Niedermayer wrote:
>> On Tue, Nov 23, 2010 at 10:44:03PM +0100, Stefan Gehrer wrote:
>>> Hi,
>>>
>>> attached patch fixes seeking in a particular ASF file I have
>>> but unfortunately can not share.
>>> The ASF spec specifically mentions that non-standard
>>> top-level objects as well as the 'Index Object' go between
>>> the 'Data Object' and the 'Simple Index Object', but in contrast
>>> in asf_build_simple_index the assumption seems to be that the
>>> 'Simple Index Object' follows immediately after the 'Data Object'.
>>> The file I have has an 'Index Object' in that position which
>>> is skipped with this patch, making the file seekable.
>>>
>>> Stefan
>>
>>>   asfdec.c |   15 ++++++++++++++-
>>>   1 file changed, 14 insertions(+), 1 deletion(-)
>>> ebc53d12b4cde282e6bfbe076120eed4dd048bda  asfdec_seekfix.patch
>>
>> lgtm
>
> Thanks, applied.
>
> The code block after that now is unconditional. Do you want me to
> decrease the indention level and move the variable declarations
> to the top of the function?

if you like ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101203/091d1fce/attachment.pgp>