[FFmpeg-devel] [PATCH] Add av_file_get_size() and av_file_read(), replace cmdutils.h:read_file().

[Stefano Sabatini]

On date Thursday 2010-12-02 02:32:30 +0100, Michael Niedermayer encoded:
[...]
> > +/**
> > + * Read the file with name filename, and put its content in a newly
> > + * allocated 0-terminated buffer. If filename references a link, the
> > + * content of the linked file is read.
> > + *
> > + * @param bufptr location where pointer to buffer is returned
> > + * @param size   location where size of buffer is returned
> > + * @param log_ctx context used for logging
> > + * @return 0 in case of success, a negative value corresponding to an
> > + * AVERROR error code in case of failure
> > + */
> > +int av_file_read(const char *filename, char **bufptr, size_t *size, void *log_ctx);
> 
> this API is crap.
> at a minimunm it should support memory mapped files on platforms supporting them

We could have a:
int av_file_get(const char *filename, size_t *size, void *log_ctx);

(alternative name: av_file_open())

which returns the filedes and the size performing the boring checks,
then the application may suck the content in a buffer or using mmap()
access. Would be this acceptable?
-- 
FFmpeg = Foolish & Fierce Mystic Picky Ermetic Gospel