[FFmpeg-devel] [PATCH] Port gradfun to libavfilter (GCI)

[Stefano Sabatini]

On date Wednesday 2010-12-08 15:12:38 -0500, Nolan L encoded:
> On Tue, Dec 7, 2010 at 2:13 PM, Stefano Sabatini <
> stefano.sabatini-lala at poste.it> wrote:
> 
> > is this -((-foo)>>bar) required? (why not simply foo>>bar)?
> >
> 
> The double negation was the way that the code in mplayer worked. Without
> knowing why it was originally like that, I am hesitant to change it now.

Keep that, I was confused (and the code obfuscated but that's another
issue).

> useless (well technically it is not yet clear the semantics of video->w,h)
> >
> 
> I saw this code from another filter which used a similar rendering
> technique; should I remove it?

I suppose it is safe to keep it.

Nolan, please send an updated version with the other nits fixed. I'll
apply the patch in few days if there are no more comments.
-- 
FFmpeg = Frightening and Formidable Mega Patchable Erroneous Gadget