[FFmpeg-devel] [RCF] lavfi aspect ratio setting path
Baptiste Coudurier
baptiste.coudurier
Sun Dec 12 21:34:10 CET 2010
On 12/3/10 9:53 PM, Baptiste Coudurier wrote:
> On 12/2/10 6:28 PM, Michael Niedermayer wrote:
>> On Mon, Nov 29, 2010 at 03:26:40AM -0800, Baptiste Coudurier wrote:
>> [...]
>>> @@ -419,6 +430,10 @@
>>>
>>> codec->width = ist->output_video_filter->inputs[0]->w;
>>> codec->height = ist->output_video_filter->inputs[0]->h;
>>> + ost->st->sample_aspect_ratio = codec->sample_aspect_ratio =
>>
>>> + frame_aspect_ratio == 0 ? // overriden by the -aspect cli option
>>> + av_d2q(frame_aspect_ratio*codec->height/codec->width, 255) :
>>> + ist->output_video_filter->inputs[0]->sample_aspect_ratio;
>>
>> that looks odd if frame_aspect_ratio == 0 then
>> av_d2q(frame_aspect_ratio*codec->height/codec->width, 255)
>> will be used
>> but thats av_d2q(0*codec->height/codec->width, 255)=0
>
> Yes you are right, it required more modifications to make it work.
> Updated patch.
>
Ping.
--
Baptiste COUDURIER
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer http://www.ffmpeg.org
More information about the ffmpeg-devel
mailing list