[FFmpeg-devel] [PATCH 0/4] floating-point AC-3 encoder

[Vitor Sessak]

On 12/22/2010 03:30 PM, Justin Ruggles wrote:
>
> These 4 patches add floating-point support to the AC-3 encoder.

Nice!!

> There are a few ways this could be done, but I chose what I thought
> was the simplest approach.  ac3enc.c #includes ac3enc_fixed.c/h or
> ac3enc_float.c/h depending on CONFIG_AC3ENC_FLOAT as selected during
> configure.
>
> I'm not sure how the regression tests will turn out due to the use of
> floating-point.  I changed the references to match my system, but it
> would be good to have some tests from different systems so we know
> beforehand if FATE would turn yellow.

This is one of the two hardest things to add to FATE ATM: floating point 
encoders (for ex. AAC) and network protocols. I'd say that for float 
encoders doing encode-decode-compare_PSNR is better than nothing. For 
the network protocols, we will need to cook up some session 
player/recorder, which looks a bit more tricky. Suggestions are welcome.

-Vitor