[FFmpeg-devel] [PATCH] av_find_best_stream

[Michael Niedermayer]

On Sun, Dec 26, 2010 at 01:13:22AM +0100, Nicolas George wrote:
> Le quintidi 5 niv?se, an CCXIX, Michael Niedermayer a ?crit?:
> > > +/**
> > >   * Read a transport packet from a media file.
> > >   *
> > >   *
> > This function is obsolete and should never be used.
> 
> I am not sure what you are talking about here. If this is about
> av_read_packet, this patch does nothing with it, it just inserts something
> before (near av_find_stream_info seemed like the right place for
> av_find_best_stream), and diff picks the wrong "/**".

LOL, look, the text was:
+int av_find_best_stream(AVFormatContext *ic,
+                        enum AVMediaType type,
+                        int wanted_stream_nb,
+                        int related_stream,
+                        AVCodec **decoder_ret,
+                        int flags);
+
+/**
  * Read a transport packet from a media file.
  *
  * This function is obsolete and should never be used.
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 61aa7d4..ed24d31 100644
----------------------------

I dont know how it happened but somehow i must have hit the wrong keys at the
wrong time without realizing, that or the KGB agents had a vodka too much when
editing my mail ;)

[...]






> 
> > the dox seem not to mention this
> 
> Sorry, that was a leftover from the code from ffplay, it was completely
> wrong.
> 
> Regards,
> 
> -- 
>   Nicolas George

>  doc/APIchanges         |    3 ++
>  ffplay.c               |   46 ++++++++++++++----------------------
>  libavformat/avformat.h |   31 ++++++++++++++++++++++++
>  libavformat/utils.c    |   61 +++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 113 insertions(+), 28 deletions(-)
> 8bd7d525e76627727b6a2b4e3f418c97126a9c2a  ffmpeg-findstream-20101226-0109-01-findstream.diff
>  doc/APIchanges         |    3 ++
>  ffplay.c               |   46 ++++++++++++++----------------------
>  libavformat/avformat.h |   31 ++++++++++++++++++++++++
>  libavformat/utils.c    |   61 ++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 113 insertions(+), 28 deletions(-)

lgtm if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101226/e32177d3/attachment.pgp>