[FFmpeg-devel] [PATCH] dca: export profile information on decode

[Kostya]

On Mon, Dec 27, 2010 at 04:51:06AM +0200, Anssi Hannula wrote:
> ---
> This patch makes the dca decoder provide profile information of the
> stream, so that users can easily differentiate between the DTS types.
> 
> Couple of things related to this I'm not sure of:
> - The values of the profile #defines. In this patch I put them into an
>   approximate order of quality, with space in between for future
>   profiles. Is this OK, or should I just make them sequential from 0?

I'd rather not do it this way - first, one should detect HD part in
frame ( which is easy) and divide profile into HRA or base, then if needed
scan core part for X96k/XCh/XXCh extensions and set profile according to
that. HD part has too complex structure - it may contain several
substreams (or ass-ets as they call it), each one with its own
capabilities. So unless you can parse it properly better not touch it at
all.

> - I used FF_PROFILE_DTS. Should FF_PROFILE_DCA be used instead? (we have
>   CODEC_ID_DTS but the decoder name is "dca")

Well, the codec is DTS, DCA is used mostly as tribute for
libdts^Wlibdca, which we used as a base for our decoder.

[...]