[FFmpeg-devel] [PATCH][0.5] Fix building on the hurd

[Reimar Döffinger]

On Mon, Feb 01, 2010 at 09:38:41PM +0100, Reinhard Tartler wrote:
> On Mo, Feb 01, 2010 at 21:22:10 (CET), Reimar D?ffinger wrote:
> 
> > On Mon, Feb 01, 2010 at 09:04:52PM +0100, Reinhard Tartler wrote:
> >> 
> >> Author: Andres Mejia <mcitadel at gmail.com>
> >> Fix build failures for the GNU Hurd OS
> >> 
> >> please approve for branches/0.5
> >> 
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1651,6 +1651,9 @@ case $target_os in
> >>          ;;
> >>      gnu/kfreebsd)
> >>          ;;
> >> +    gnu)
> >> +        disable dv1394
> >> +        ;;
> >
> > How does it fail?
> 
> It fails to build.
> 
> > There certainly should be a proper autodetection for that feature?
> > Actually, considering it only seems to require ioctl and mmap is there
> > much of a point to disable this feature?
> 
> The hurd does not seem to have firewire support at all. Moreover, the
> proposed patch is actually a backport of trunk, and therefore I think it
> is valid on its own.

If it is then I must be blind again today, because I can't see anything
like that in trunk.

> For completeness, I think this is the relevant debian bug report:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=372290. It was reported
> by a hurd porter, and I generally tend to trust porters.

If that's all you have you can't know that enabling dv1394 causes the build to fail,
it may just have been the --enable-dc1394 alone that caused the issue, or the v4l
or the bktr code.
But even if it did, the dv1394 code quite obviously was designed to be stand-alone,
so if the build fails due to missing dv1394 support in the kernel headers or something
like that, that would probably be a bug in the code that should be fixed _first_.
(I also wonder a bit with what exactly you mean by "trust porters", trust them to be
knowledgeable enough with the project they try to port to always know the correct
way to fix a problem? That seems expecting a bit too much. If not, the basic rules
for bug reporting should apply to them as well)