[FFmpeg-devel] [PATCH] Indeo 5 decoder

[Maxim]

pross at xvid.org schrieb:
> On Mon, Feb 01, 2010 at 09:17:41AM +0200, Kostya wrote:
>   
>> $subj
>>     
>
>   
>> +/**
>> + * @file libavcodec/indeo5data.h
>> + * This file contains data needed for the Indeo5 decoder.
>> + */
>> +
>> +#ifndef AVCODEC_INDEO5DATA_H
>> +#define AVCODEC_INDEO5DATA_H
>> +
>> +#include <stdint.h>
>> +
>> +/**
>> + *  standard picture dimensions (width, height)
>> + */
>> +static uint16_t ivi5_common_pic_sizes[30] = {640, 480, 320, 240, 160, 120, 704, 480, 352, 240, 352, 288, 176, 144,
>> +                                             240, 180, 640, 240, 704, 240,  80,  60,  88,  72,   0,   0,   0,   0, 0, 0};
>>     
>
> these would fit in uint8_t if you divided everyting by 4.
>   

Sorry guys, but I think it would make the code less readable IMHO. I
don't see much sense in obfuscating this tiny table in order to save 30
bytes of memory...
Plz don't be angry, it's just my opinion...

Regards
Maxim