[FFmpeg-devel] [PATCH] urlconcat protocol

[Michele Orrù]

fixed .


2010/2/3 Stefano Sabatini <stefano.sabatini-lala at poste.it>

    On date Monday 2010-02-01 22:53:17 +0100, Michele Orr? encoded:
    > 2010/1/31 Michael Niedermayer <michaelni at gmx.at>

    > Index: libavformat/concat.c
    [...]
    > +#define AV_CAT_SEPARATOR "|"

    why a string not a char?


strspn and  strcspn need both a string, so it's easier to play with a
string.


    > +
    > +struct urlconcat_nodes {
    > +    URLContext *uc;

    > +    int64_t     size;

    A doxy may be useful here.

Done, but this seems trivial to me.


    > +    if (!(unodes = av_malloc(sizeof(*unodes) * len))) {

    you can check here with:
    if ((uint64_t)(sizeof(*unodes)) * len > UINT_MAX) ...

    or something similar.

len, at start, is surely < UINT_MAX / sizeof(*unodes), so we can check also
without converting to a uint64_t and with a ==,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uconcatp.patch
Type: application/octet-stream
Size: 6779 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100205/06c8c998/attachment.obj>