[FFmpeg-devel] [PATCH] avi metadata conv table

[Anton Khirnov]

On Fri, Feb 05, 2010 at 08:48:53PM +0100, Michael Niedermayer wrote:
> On Fri, Feb 05, 2010 at 08:36:56PM +0100, Anton Khirnov wrote:
> > On Fri, Feb 05, 2010 at 07:43:22PM +0100, Michael Niedermayer wrote:
> > > 
> > > char key[5]={0}
> > > AV_WL32(key, tag);
> > > (simpler IMHO)
> > > 
> > done
> > > 
> > > nothing in there uses AVFormatContext thus the changes is pointless
> > > 
> > right, fixed
> > > 
> > > [...]
> > > > @@ -378,15 +366,13 @@ static int avi_write_header(AVFormatContext *s)
> > > >  
> > > >      list2 = ff_start_tag(pb, "LIST");
> > > >      put_tag(pb, "INFO");
> > > > -    avi_write_info_tag2(s, NULL, "INAM", "Title", NULL);
> > > > -    avi_write_info_tag2(s, NULL, "IART", "Artist", "Author");
> > > > -    avi_write_info_tag2(s, NULL, "ICOP", "Copyright", NULL);
> > > > -    avi_write_info_tag2(s, NULL, "ICMT", "Comment", NULL);
> > > > -    avi_write_info_tag2(s, NULL, "IPRD", "Album", NULL);
> > > > -    avi_write_info_tag2(s, NULL, "IGNR", "Genre", NULL);
> > > > -    avi_write_info_tag2(s, NULL, "IPRT", "Track", NULL);
> > > 
> > > > -    if(!(s->streams[0]->codec->flags & CODEC_FLAG_BITEXACT))
> > > > -        avi_write_info_tag(pb, "ISFT", LIBAVFORMAT_IDENT);
> > > 
> > > you seem to be loosing this in your patch
> > > 
> > fixed
> > 
> > btw i was wondering if it really belongs here and not in the client app.
> 
> it absolutely belongs in the muxer

maybe it should be set at some higher level then, for example in
av_metadata_conv(). adding special case like this to each muxer
is quite ugly.
> 
> mixing cosmetics with functional changes
> 
oops, sorry. fixed

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-AVI-metadata-conversion-table.patch
Type: text/x-diff
Size: 9967 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100205/efa94c4d/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100205/efa94c4d/attachment.pgp>