[FFmpeg-devel] [PATCH]set lavf ident string globally

[Michael Niedermayer]

On Mon, Feb 08, 2010 at 04:45:54PM +0100, Anton Khirnov wrote:
> Hi,
> attached patch moves setting LIBAVFORMAT_IDENT for muxers to
> av_write_header(), so they no longer have to treat it as na ugly
> special case. This is immediately used in mp3 and avi muxers and will
> potentially be useful for at least nut, ogg and possibly some other.
> 
> Anton Khirnov
> 

>  avi.c      |    2 +-
>  avienc.c   |    2 --
>  metadata.c |    2 +-
>  metadata.h |    3 +++
>  mp3.c      |    7 +------
>  utils.c    |   14 ++++++++++++++
>  6 files changed, 20 insertions(+), 10 deletions(-)
> 3c141763180f301f46900391835697756589b981  0001-Set-lavf-identification-string-globally.patch

iam mildly against this patch.
the libavformat ident string is very important for dealing with muxer bugs
on the demuxer side in the future.
Setting it outside the demuxer like this makes it much easier to
break it somehow without us noticing

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100210/9bdb033b/attachment.pgp>