[FFmpeg-devel] [PATCH] improvement on r21598 ("fix stream copy")

[Michael Niedermayer]

On Thu, Feb 11, 2010 at 07:23:02PM -0000, Wolfram Gloger wrote:
> > Date: Wed, 10 Feb 2010 15:26:45 +0100
> > From: Michael Niedermayer <michaelni at gmx.at>
> 
> > On Sun, Feb 07, 2010 at 11:58:08AM -0000, Wolfram Gloger wrote:
> > > > From: Michael Niedermayer <michaelni at gmx.at>
> > > >=20
> > > > well, what you write is a rather terse analysis ...
> > > > because really the tests should match unless predicted and real timesta=
> > mps
> > > > differ and of course ignoring the current rounding bug reimar is workin=
> > g on
> > >=20
> > > I think the rounding issue is orthogonal.
> > >=20
> > > The test for pkt.pts which you added in r21598 is done for _every_
> > > packet passing the main loop.
> > >=20
> > > The test for opts_min OTOH can only hit if the predicted timestamps
> > > for _all_ streams are bigger than recording time, i.e. if N packets
> > > with dts+duration>recording_time have already been written.
> > >=20
> > > So the tests do not match, one can get in a situation where only the
> > > first test hits, even when all predicted timestamps equal "real"
> > > timestamps.
> > >=20
> > > > anyway, with your patch the opts_min test should be redundant and could
> > > > be removed
> > >=20
> > > That is true, "make test" does still pass for me after removing the
> > > opts_min test.  Let me know if you want that incorporated in the patch
> > > or separately.
> > 
> > seperately
> 
> Ok, here goes.  Changelog suggestion:
> 
> Remove recording_time check which is no longer necessary after r21687.
> 
> Passes make test on amd64.
> 
> Regards,
> Wolfram.

>  ffmpeg.c |    4 ----
>  1 file changed, 4 deletions(-)
> 930bd6ce9485a8b1a92c4731b78cbd1a21ff50c3  ffmpeg-opts-min.diff

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100212/b013fc4b/attachment.pgp>