[FFmpeg-devel] [PATCH] fix some warnings in h264

[Michael Niedermayer]

On Sat, Feb 13, 2010 at 05:47:42AM -0500, Alexander Strange wrote:
> As attached.
> 
> There are a few warnings left in h264_direct.c that could maybe be fixed by removing 'const'.

>  h264.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 17ae11154512a92211c66b1bc28064ce460a314f  0001-Fix-integer-overflow-warnings-in-h264.h.patch
> From dc02adae10811cbb01f0a4c29d312a419de5f022 Mon Sep 17 00:00:00 2001
> From: Alexander Strange <astrange at ithinksw.com>
> Date: Sat, 13 Feb 2010 05:33:18 -0500
> Subject: [PATCH 1/3] Fix integer overflow warnings in h264.h.
> 
> Fixes:
> h264.h: In function 'fill_filter_caches':
> h264.h:1216:73: warning: integer overflow in expression
> h264.h:1307:81: warning: integer overflow in expression

ok

[...]
>  h264.c            |    4 +---
>  h264.h            |    1 -
>  h264_loopfilter.c |    5 ++---
>  3 files changed, 3 insertions(+), 7 deletions(-)
> 56b1eb4f2c3a843390bb511cf55d743571ffb923  0003-h264-Remove-unused-variables.patch
> From abc79867e252228e0b73a3d5fe11909f4741f1a3 Mon Sep 17 00:00:00 2001
> From: Alexander Strange <astrange at ithinksw.com>
> Date: Sat, 13 Feb 2010 05:42:32 -0500
> Subject: [PATCH 3/3] h264: Remove unused variables.
> 
> ---
>  libavcodec/h264.c            |    4 +---
>  libavcodec/h264.h            |    1 -
>  libavcodec/h264_loopfilter.c |    5 ++---
>  3 files changed, 3 insertions(+), 7 deletions(-)

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100213/c5cb6a31/attachment.pgp>