[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

[James Darnley]

On 14 February 2010 02:13, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> What specifically did you try to do that did not work? ?You should not
> need to have year and author converted since the generic tags should
> already be date and artist.

I have attached another patch which removes these two.  I was confused
but a quick discussion on #ffmpeg-devel straightened me out.  (It
would already be here if my ISP hadn't cut off my connection last
night)

>> [...]
>> + ? ?/* The command line flac encoder defaults to placing a seekpoint
>> + ? ? * every 10s. ?So one might add padding to allow that later
>> + ? ? * but there seems to be no simple way to get the duration here.
>> + ? ? * So let's try the flac default of 8192 bytes */
>> + ? ?flac_write_block_padding(s->pb, 8192, 1);
>
>
> I would recommend adding the writing of a padding block in a separate
> commit. ?It is unrelated to writing of VorbisComment tags, and it is the
> cause of the change to the regression tests.

I could submit this as another patch but adding VorbisComment writing
already changes the test results.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg_flac-tags_18_r21815M.diff
Type: application/octet-stream
Size: 13261 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100214/81f50882/attachment.obj>