[FFmpeg-devel] [PATCH] ffprobe integration

[Stefano Sabatini]

On date Monday 2010-02-15 02:22:09 +0100, Michael Niedermayer encoded:
> On Mon, Feb 15, 2010 at 12:59:13AM +0100, Stefano Sabatini wrote:
[...]
> > +/* globals */
> > +static const OptionDef options[];
> > +
> > +/* FFprobe context */
> > +static const char *input_filename;
> > +
> > +static const char *binary_unit_prefixes[] = { "", "Ki", "Mi", "Gi", "Ti", "Pi" };
> 
> > +static const int binary_unit_prefixes_nb = FF_ARRAY_ELEMS(binary_unit_prefixes);
> 
> please use FF_ARRAY_ELEMS() directly
> 
> 
> [...]
> 
> > +static char *time_value_string(char *buf, int buf_size, int64_t val, AVRational *time_base)
> 
> time_base should be const if you pass it as pointer
> 
> 
> [...]
> > +    printf("size=%s\n",             value_string(val_str, sizeof(val_str), (double)fmt_ctx->file_size,
> > +                                                 unit_byte_str));
> 
> useless cast

Fixed.

Also performed some move-around and added some notes in the
documentation.

Regards.
-- 
FFmpeg = Fundamental and Formidable Muttering Perennial EnGine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-ffprobe.patch
Type: text/x-diff
Size: 17501 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100216/e0545805/attachment.patch>