[FFmpeg-devel] [PATCH] HE-AAC v1 decoder try 4

[Måns Rullgård]

Vitor Sessak <vitor1001 at gmail.com> writes:

> Alex Converse wrote:
>> On Tue, Feb 16, 2010 at 6:01 PM, Alex Converse <alex.converse at gmail.com>wrote:
>
> My final comments:
>
>>> Notes:
>>> *All the computation time is spent in ff_sbr_apply() and it's
>>> children. If it isn't called from ff_sbr_apply() making it 100% faster
>>> isn't going to buy us anything.
>>> *Right now the synthesis filterbank is written on top on an MDCT. With
>>> appropriate SIMD functions it may make sense to move it to an FFT.
>>> Right now the MDCT version is much faster.
>
> Since you have already done it, can you send it so we can have a look?
>
> Also if you still have the butterflies without the scratch buffer, I'd
> like also to have a look. I'd like to understand why it is slower.
>
>> +static VLC vlc_sbr[10];
>> +static const int8_t vlc_sbr_lav[10] =
>> +    { 60, 60, 24, 24, 31, 31, 12, 12, 31, 12 };
>> +static DECLARE_ALIGNED_16(float, analysis_cos_pre)[64];
>> +static DECLARE_ALIGNED_16(float, analysis_sin_pre)[64];
>> +static DECLARE_ALIGNED_16(float, analysis_cossin_post)[32][2];
>> +static DECLARE_ALIGNED_16(float, zero64)[64];
>
> Would the following work?
>
> static const DECLARE_ALIGNED_16(float, zero64)[64] = {0};

Useless assignment.

-- 
M?ns Rullg?rd
mans at mansr.com