[FFmpeg-devel] [PATCH] RTSP muxer, round 4

[Ronald S. Bultje]

Hi,

On Fri, Feb 19, 2010 at 4:50 PM, Martin Storsj? <martin at martin.st> wrote:
> On Fri, 19 Feb 2010, Ronald S. Bultje wrote:
>> On Fri, Feb 19, 2010 at 11:27 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> > On Fri, Feb 19, 2010 at 2:41 AM, Martin Storsj? <martin at martin.st> wrote:
>> >> Here's the latest version of the RTSP muxer, addressing Ronalds latest
>> >> comments.
>> >
>> > Patch 0001 is applied also (r21896).
>> >
>> > I'm checking to make sure the use of is_output is necessary and then
>> > I'll apply that also.
>>
>> + ? ?/** This flag says if this is an output or input context. */
>> + ? ?int is_output;
>>
>> I'm wondering if we discussed this before. Can you use
>> AVFormatContext->oformat != NULL instead of is_output? Or something
>> along those lines?
>
> Ah, that would work, yes. However, at some of the places where it is used
> (rtsp_close_streams), there's no AVFormatContext pointer available, only
> RTSPState, but that can be fixed of course. Do you want me to try that
> approach?

If possible, yes. Having a AVFormatContext around would also be useful
if we want to add calls to av_log() or so.

Ronald