[FFmpeg-devel] [PATCH] asfenc: fix extended content header

[Michael Niedermayer]

On Sat, Feb 20, 2010 at 04:09:06PM +0100, Anton Khirnov wrote:
> On Sat, Feb 20, 2010 at 11:04:59AM +0100, Michael Niedermayer wrote:
> > 
> > if its really useless it could be skiped with a AV_LOG_DEBUG msg
> > anyway, what are the names of these byte array valued tags?
> > 
> not counting these broken ID3, i saw ASFLeakyBucketPairs tag in some of
> my files. according to [1] it provides some buffering-related hints.
> [2] contains a list of other binary attributes, so if somebody is
> interested in reading them (i'm not) he can implement it.
> 
> however what we most certainly shouldn't do is attempt to read this
> binary data as strings.
> 
> patch with message level lowered to debug attached.
> 
> Anton Khirnov
> 
> [1] http://msdn.microsoft.com/en-us/library/dd743054(VS.85).aspx
> [2] http://msdn.microsoft.com/en-us/library/dd743066(VS.85).aspx

>  asfdec.c |   16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 05d0c9d611db817283bd54e08af9b1225b9c868e  0001-asfdec-don-t-try-to-read-byte-array-tags-in-extended.patch
> From 20f7bc0971b1df7ef80bafce3d9eddad66ff9d53 Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Thu, 18 Feb 2010 19:03:18 +0100
> Subject: [PATCH] asfdec: don't try to read byte array tags in extended content header.
> 
> ---
>  libavformat/asfdec.c |   16 +++++++++++++---
>  1 files changed, 13 insertions(+), 3 deletions(-)

i dont think you need 10 new lines to add 1 line (av_log)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100220/95889e3c/attachment.pgp>