[FFmpeg-devel] [PATCH] asfenc: fix extended content header

[Michael Niedermayer]

On Sun, Feb 21, 2010 at 03:54:40PM +0100, Anton Khirnov wrote:
> On Sun, Feb 21, 2010 at 01:34:14PM +0100, Michael Niedermayer wrote:
> > 
> > the patch replaces if() by switch/case
> > the patch fixes a memleak by adding av_free (should be av_freep)
> > it adds an av_log()
> > and it drops handling of the byte array case
> > 
> > i guess you should send 4 patches, this would avoid misundderstandings
> > (if->switch rejected)
> > (av_log needs +1 line)
> > (av_free needs +1 line)
> > (byte arary change +0 line)
> > 
> switch looked nicer to me, but whatever. fixed and split
> 
> Anton Khirnov

>  asfdec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> d5b6cfbf48c37295ced67c4ab5c4b835acf0f627  0001-asfdec-only-unicode-tags-must-have-even-length.patch
> From 84357b8d7be5bd7587ac9268d3ffcea06703bcca Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Thu, 18 Feb 2010 19:04:17 +0100
> Subject: [PATCH 1/4] asfdec: only unicode tags must have even length.

ok if tested
[...]

>  asfdec.c |    1 +
>  1 file changed, 1 insertion(+)
> d6d24f3a1154b743e761d2e9066b8a3ce076ed2c  0002-asfdec-fix-a-memleak.patch
> From 3be00f3374afe25e91dafa9ad727096a886a7d10 Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Thu, 18 Feb 2010 19:03:18 +0100
> Subject: [PATCH 2/4] asfdec: fix a memleak.

ok
[...]

>  asfdec.c |    1 +
>  1 file changed, 1 insertion(+)
> c604b1c35807a61441b75b2d28157a059d2df2d7  0003-asfdec-add-a-debug-message-about-skipped-tags.patch
> From b549aa4dbf4bef001d09031267a30beee8e19f92 Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Sun, 21 Feb 2010 15:46:27 +0100
> Subject: [PATCH 3/4] asfdec: add a debug message about skipped tags.

ok
8...]

>  asfdec.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 9406b374fef767b6d41ff69f8e18d7b901cfc300  0004-asfdec-skip-byte-array-tags.patch
> From 4445128d92fa90ace27f78c8ef18102ba8b5522c Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Sun, 21 Feb 2010 15:48:39 +0100
> Subject: [PATCH 4/4] asfdec: skip byte array tags.

ok, though i would prefer id3 to be parsed too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/1ae083ae/attachment.pgp>