[FFmpeg-devel] [PATCH] fix warning in vc1dec.c

[Michael Niedermayer]

On Sun, Feb 21, 2010 at 04:55:56PM +0100, Reimar D?ffinger wrote:
> On Sun, Feb 21, 2010 at 04:53:50PM +0100, Janne Grunau wrote:
> > Hi,
> > 
> > fixes following warning
> > libavcodec/vc1dec.c: In function ?vc1_decode_p_mb?:                                                     
> > libavcodec/vc1dec.c:2319: warning: suggest parentheses around operand of ?!? or change ?&? to ?&&? or ?!? to ?~?
> > 
> > 
> > diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
> > index 611b845..f607949 100644
> > --- a/libavcodec/vc1dec.c
> > +++ b/libavcodec/vc1dec.c
> > @@ -2316,7 +2316,7 @@ static int vc1_decode_p_mb(VC1Context *v)
> >                  }
> >                  if(i == 4) vc1_mc_4mv_chroma(v);
> >                  v->mb_type[0][s->block_index[i]] = is_intra[i];
> > -                if(!coded_inter) coded_inter = !is_intra[i] & is_coded[i];
> > +                if(!coded_inter) coded_inter = !is_intra[i] && is_coded[i];
> 
> There are concerns this will result in slower code.
> Unless we can get a decision, I'd suggest just adding a () to silence the compiler.

can we pipe the compiler output through egrep -v ?
or can this one be disabled by a compiler switch without disabling other
usefull warnings?

I really think obfuscating code or slowing it down is not a solution.
we cant just change every piece of code some gcc version warns about.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/7e118b67/attachment.pgp>