[FFmpeg-devel] [PATCH] Add AMR-NB decoder, next try

Vitor Sessak vitor1001
Sun Feb 21 19:03:41 CET 2010


Vitor Sessak wrote:
> Ronald S. Bultje wrote:
>> Hi,
>>
>> On Thu, Feb 18, 2010 at 3:03 PM, Vitor Sessak <vitor1001 at gmail.com> 
>> wrote:
>>> Vitor Sessak wrote:
>>>> Ronald S. Bultje wrote:
>>>>> On Sun, Jan 24, 2010 at 7:02 PM, Vitor Sessak <vitor1001 at gmail.com>
>>>>> wrote:
>>>>>> New patch attached, thanks Collin for the changes.
>>>> [... review ...]
>>>>
>>>> All comments fixed, new patch attached.
>>> ping
>>
>> No more comments from me.
>>
>> If you specifically want something, there's a lot of memcpy()s all
>> around, can these be prevented? I'm prety sure you already looked at
>> it, but since you're RFCing...
> 
> Most of the memcpys are for updating synthesis memory, and not really 
> preventable. If nobody else reviews or ask for more time I'll commit in 
> a couple of days.

Applied. One step closer to world domination ;)

-Vitor



More information about the ffmpeg-devel mailing list