[FFmpeg-devel] [Patch] Use Transfer-Encoding: chunked (and perhaps PUT) for HTTP uploads

[Michael Niedermayer]

On Thu, Dec 31, 2009 at 03:09:41PM +0100, Tomas H?rdin wrote:
> On Tue, 2009-12-22 at 13:56 +0000, Mans Rullgard wrote:
> > 
> > "Diego Biurrun" <diego at biurrun.de> wrote:
> > 
> > >On Tue, Dec 22, 2009 at 12:52:29PM +0000, Mans Rullgard wrote:
> > >> 
> > >> 
> > >> "Diego Biurrun" <diego at biurrun.de> wrote:
> > >> 
> > >> >On Tue, Dec 22, 2009 at 01:22:07PM +0100, Tomas H?rdin wrote:
> > >> >> 
> > >> >> --- libavformat/http.c	(revision 20911)
> > >> >> +++ libavformat/http.c	(working copy)
> > >> >> @@ -344,13 +348,49 @@
> > >> >> +
> > >> >> +        if ((ret = url_write(s->hd, temp, strlen(temp))) < 0)
> > >> >> +            return ret;
> > >> >> +
> > >> >> +        /* chunk-data */
> > >> >> +        if ((ret = url_write(s->hd, buf, size)) < 0)
> > >> >> +            return ret;
> > >> >> +
> > >> >> +        /* CRLF */
> > >> >> +        if ((ret = url_write(s->hd, crlf, sizeof(crlf) - 1)) < 0)
> > >> >> +            return ret;
> > >> >
> > >> >These if statements can be merged ..
> > >> 
> > >> No.
> > >
> > >Hehe, yes, but they can be compacted with 'else'. :)
> > 
> > That will hardly improve readability.
> 
> Sorry for not responding earlier, but I was up in the swedish mountains
> bereft of internet access for a week during christmas.
> 
> It seems you can't quite agree on which style to use, so I made two more
> patches with slightly different style. I'm attaching all four style
> variants for this patch. Please pick one so I can post the other HTTP
> patches.
> 
> In short, their differences are:
> 
[...]
> v2: compacted with || in http_write() and && in http_close()

i think this is ok if tested unless we have some volunteer to maintain http.c
iam after all not ideal for the http maintainer role as i dont know the fine
details of it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100101/a50524ec/attachment.pgp>