[FFmpeg-devel] [PATCH] ffprobe integration

[Diego Biurrun]

On Sat, Jan 02, 2010 at 06:46:11PM +0100, Stefano Sabatini wrote:
> 
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/ffprobe.c	2010-01-02 18:41:15.000000000 +0100
> @@ -0,0 +1,471 @@
> +/*
> + * This file is part of FFmpeg.
> + *
> + * FFprobe is free software; you can redistribute it and/or

FFprobe or FFmpeg?

> +const char *binary_unit_prefixes[] = {
> +    "",
> +    "Ki",
> +    "Mi",
> +    "Gi",
> +    "Ti",
> +    "Pi"
> +};
> +
> +const char *decimal_unit_prefixes[] = {
> +    "",
> +    "K",
> +    "M",
> +    "G",
> +    "T",
> +    "P"
> +};

Those are a lot of lines..

> +        usecs= (int) (round((val - floor(val)) * 1000000));
> +        secs= (int) val;
> +        mins = secs / 60;
> +        secs %= 60;
> +        hours = mins / 60;
> +        mins %= 60;

Sometimes you have spaces around =, sometimes you don't, more below..

> +static void show_stream(AVInputStream *ist) {

Sometimes you use K&R function declarations, sometimes you don't...

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/doc/ffprobe-doc.texi	2010-01-02 18:44:56.000000000 +0100
> @@ -0,0 +1,75 @@
> +
> +FFprobe is a very simple and portable prober using the FFmpeg
> +libraries to probe the content of a file.

I would suggest s/prober/program/.

> +It may be used to print informations about the format and header of a

The word "information" has no plural.

> +multimedia file or stream, the multimedia streams and each single
> +packet or frame.

a multimedia stream, the multimedia streams - you talk about these two
things as if they were not the same..

> +FFprobe output consists in stanza of the form:

a stanza

> +and is designed in order to be easily parsable by a textual filter.

designed to be

> +FFprobe may be used both as a standalone application or in combination with
> +a textual filter, which is supposed to perform more sophisticated
> +elaboration (e.g. statistics elaboration or plotting).

elaboration?

Diego