[FFmpeg-devel] [PATCH] A few more MP4 metadata fields

[Mike Melanson]

Baptiste Coudurier wrote:
> Hi Mike,
> 
> On 12/30/09 2:26 PM, Mike Melanson wrote:
>> Mike Melanson wrote:
>>> This patch adds a few more metadata tags for MP4 files, for
>>> completeness. This is pursuant to my FFmpeg metadata survey here:
>>>
>>> http://multimedia.cx/eggs/supplying-ffmpeg-with-metadata/
>>
>> Patch forgotten, per sacred tradition.
>>
>>
>> mov-metadata.patch
>>
>>
>> Index: ../ffmpeg-main/libavformat/movenc.c
>> ===================================================================
>> --- ../ffmpeg-main/libavformat/movenc.c    (revision 20983)
>> +++ ../ffmpeg-main/libavformat/movenc.c    (working copy)
>> @@ -1434,6 +1434,7 @@
>>       put_tag(pb, "ilst");
>>       mov_write_string_metadata(s, pb, "\251nam", "title"    , 1);
>>       mov_write_string_metadata(s, pb, "\251ART", "author"   , 1);
>> +    mov_write_string_metadata(s, pb, "\141ART", "album_artist", 1);
> 
> Isn't it "aART" ?

Yes, which is also 141 in octal. Hmm, I didn't notice that with my hex 
editor. :)

> Rest is ok.

Patch changed per your comments and committed. Thanks.

-- 
     -Mike Melanson