[FFmpeg-devel] [PATCH] Port VDPAU to AVHWAccel infrastructure

[Carl Eugen Hoyos]

Gwenole Beauchesne <gbeauchesne <at> splitted-desktop.com> writes:

> - It's a plain and straightforward port, no effort was made to fix  
> current bugs in the VDPAU code

Would you mind reporting them?

> (including the memory leaks)

and those?

Just two quick questions:

> - render->info.h264.is_reference = (s->current_picture_ptr->reference & 3) ?
VDP_TRUE : VDP_FALSE;
> + render->info.h264.is_reference = h->nal_ref_idc != 0;

How is this related to the rest of the patch?

[...]
> -    if (!s->current_picture_ptr) return;
> +    if (!s->current_picture_ptr) return 0;

And this?

[...]
+    /* fill VdpPictureInfoH264 struct */
+    /* fill VdpPictureInfoVC1 struct */

Please apply if you think those improve readability.

Carl Eugen