[FFmpeg-devel] [PATCH] ALS: Solve Issue 1657

[Michael Niedermayer]

On Tue, Jan 05, 2010 at 12:34:53AM +0100, Thilo Borgmann wrote:
> Am 05.01.10 00:30, schrieb Thilo Borgmann:
> > Hi,
> > 
> > issue 1657 seems to be caused by negative indices used in [].
> > See: http://roundup.ffmpeg.org/roundup/ffmpeg/issue1657
> > 
> > Using *() resolves this issue.
> > 
> > Tested with gcc 4.0 on MacOS 10.6. There were other versions/compilers
> > mentioned in roundup, maybe these could be tested by someone (you)?
> > 
> > I'm sorry, my svn still seems to be broken and produces unusable patches
> > (%ld...). Nevertheless I can apply them if the workaround is ok.
> > 
> 
> Some artifacts left in als_data.h. Ignore the old patch, updated patch
> attached.
> 
> -Thilo

>  alsdec.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 987821d84540420efa6f2e67be17094074e638f8  als_issue1657.rev1.patch
> Index: libavcodec/alsdec.c
> ===================================================================
> --- libavcodec/alsdec.c	(Revision 21025)
> +++ libavcodec/alsdec.c	(Arbeitskopie)
> @@ -%ld,%ld +%ld,%ld @@
>              y = 1 << 19;
>  
>              for (sb = 0; sb < smp; sb++)
> -                y += MUL64(lpc_cof[sb],raw_samples[smp - (sb + 1)]);
> +                y += MUL64(lpc_cof[sb], *(raw_samples + smp - (sb + 1)));

patch ok

independant of this, it could be that if lpc_cof was reversed

for (sb = 0; sb < smp; sb++)
    y += MUL64(lpc_cof[sb], raw_samples[sb]);


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100105/da337128/attachment.pgp>