[FFmpeg-devel] [PATCH] Make lsws expose supported formats - naming issue

[Stefano Sabatini]

On date Tuesday 2010-01-05 02:53:58 +0100, Michael Niedermayer encoded:
> On Tue, Jan 05, 2010 at 01:46:45AM +0100, Stefano Sabatini wrote:
> > On date Sunday 2010-01-03 01:56:45 +0100, Stefano Sabatini encoded:
> > > On date Sunday 2010-01-03 00:48:33 +0100, Stefano Sabatini encoded:
> > > > On date Saturday 2010-01-02 13:56:14 +0100, Stefano Sabatini encoded:
> > > > > Hi, as in subject.
> > > > > 
> > > > > Maybe a better solution would be to replace the macros with
> > > > > corresponding functions.
> > > > > 
> > > > > Regards.
> > > > > -- 
> > > > > FFmpeg = Furious and Faboulous Minimal Porno Evanescent Generator
> > > > 
> > > > > Index: ffmpeg/libswscale/swscale.c
> > > > > ===================================================================
> > > > > --- ffmpeg.orig/libswscale/swscale.c	2010-01-02 13:52:47.000000000 +0100
> > > > > +++ ffmpeg/libswscale/swscale.c	2010-01-02 13:54:54.000000000 +0100
> > > > > @@ -158,6 +158,11 @@
> > > > >          || (x)==PIX_FMT_YUV444P16BE   \
> > > > >      )
> > > > >  
> > > > > +int sws_is_input_supported(enum PixelFormat pix_fmt)
> > > > 
> > > > Sorry to bother but I feel unsatisfied with the name, I don't like the
> > > > interrogative form, I tend to prefer:
> > > > 
> > > > sws_input_is_supported(pix_fmt) -> pix_fmt input is supported
> > > > or even:
> > > > sws_is_supported_input(pix_fmt) -> pix_fmt is a supported input
> > > > maybe sounds better.
> > > > 
> > > > Or maybe:
> > > > sws_inputIsSupported() or sws_isSupportedInput()
> > > > 
> > > > to make it consistent with the camelCasing used in libswscale.
> > > > 
> > > > What do you guys suggest?
> > > 
> > > My proposal...
> > 
> > Ping (in the case it got missed in the patches-storm).
> 
> about the word order diego ask

Changed the subject for attracting more attention.

Regards.
-- 
FFmpeg = Fantastic and Furious Multipurpose Philosofic Extended Gadget