[FFmpeg-devel] [PATCH] Make lsws expose supported formats - naming issue

[Stefano Sabatini]

On date Wednesday 2010-01-06 01:13:48 +0100, Diego Biurrun encoded:
> On Wed, Jan 06, 2010 at 01:08:33AM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2010-01-05 02:53:58 +0100, Michael Niedermayer encoded:
> > > On Tue, Jan 05, 2010 at 01:46:45AM +0100, Stefano Sabatini wrote:
> > > > On date Sunday 2010-01-03 01:56:45 +0100, Stefano Sabatini encoded:
> > > > > On date Sunday 2010-01-03 00:48:33 +0100, Stefano Sabatini encoded:
> > > > > > On date Saturday 2010-01-02 13:56:14 +0100, Stefano Sabatini encoded:
> > > > > > > --- ffmpeg.orig/libswscale/swscale.c	2010-01-02 13:52:47.000000000 +0100
> > > > > > > +++ ffmpeg/libswscale/swscale.c	2010-01-02 13:54:54.000000000 +0100
> > > > > > > @@ -158,6 +158,11 @@
> > > > > > >  
> > > > > > > +int sws_is_input_supported(enum PixelFormat pix_fmt)
> > > > > > 
> > > > > > Sorry to bother but I feel unsatisfied with the name, I don't like the
> > > > > > interrogative form, I tend to prefer:
> > > > > > 
> > > > > > sws_input_is_supported(pix_fmt) -> pix_fmt input is supported
> 
> This variant is the smallest evil to my ears.

What about casing?

This is introducing an exception in the lsws casing convention adopted
for the API symbols, in general I don't like too much camelCasing and
even less mixed_camelCasing, but using mixed_camelCasing in this case
looks less worse than introducing an API inconsistency.

> > > > > > or even:
> > > > > > sws_is_supported_input(pix_fmt) -> pix_fmt is a supported input

This has the advantage that:
sws_is_supported_{input,output} or the camelCaseVariants have the same
prefix (more easy to grep for both variants).

Also sws_isSupported{In,Out}put look very similar to the
         isSupported{In,Out}    macros names.

> > > > > > maybe sounds better.
> > > > > > 
> > > > > > Or maybe:
> > > > > > sws_inputIsSupported() or sws_isSupportedInput()
> > > > > > 
> > > > > > to make it consistent with the camelCasing used in libswscale.
> > > > > > 
> > > > > > What do you guys suggest?
> > > > > 
> > > > > My proposal...
> > > > 
> > > > Ping (in the case it got missed in the patches-storm).
> > > 
> > > about the word order diego ask
> > 
> > Changed the subject for attracting more attention.
> 
> Attracted.

Thanks :).
-- 
FFmpeg = Faboulous and Faithless Multipurpose Powered Esoteric Gem