[FFmpeg-devel] [PATCH] H264 DXVA2 implementation

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 10:47:21AM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 10, 2010 at 04:58:30AM -0200, Ramiro Polla wrote:
> > On Sat, Jan 9, 2010 at 9:46 PM, Laurent Aimar <fenrir at videolan.org> wrote:
> > > New patch (v5) attached.
> > 
> > j-b pointed me to the vlc buildbot where this doesn't compile under
> > "-std=c99" (which is set by default in FFmpeg). I'm no C guru and I'm
> > quite tired right now, but it seems you can't use anonymous unions in
> > your dxva2api.h, such as:
> > 
> > typedef struct {
> >     union {
> >         struct {
> >             UCHAR Index7Bits     : 7;
> >             UCHAR AssociatedFlag : 1;
> >         };
> >         UCHAR bPicEntry;
> >     };
> > } DXVA_PicEntry_H264;
> 
> Yes, that's correct.
> Bitfields probably shouldn't be used for public API parts either, since
> compilers might be incompatible in how they implement them.

I forgot to say: in this case specifically you should at least make sure and
document that they work correctly both with -mms-bitfields and -mno-ms-bitfields